On Thu, 21 Oct 2010, Hao Wu wrote:
> From: Alek Du <alek.du@xxxxxxxxx>
>
> The Intel Moorestown platform has EHCI MPH and EHCI OTG host. This patch adds
> PCI probe part for them. The HNP part and SRAM part will be added in another
> patch. This patch depends on the OTG transceive and OTG client patch from Hang
> Yuan that should be accepted already.
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 84c1897..2e29931 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -1822,6 +1830,7 @@ int usb_new_device(struct usb_device *udev)
> * notifier chain (used by usbfs and possibly others).
> */
> err = device_add(&udev->dev);
> + otg_notify(udev, USB_DEVICE_ADD);
> if (err) {
> dev_err(&udev->dev, "can't device_add, error %d\n", err);
> goto fail;
I just noticed this. Do you really want to send the notification
message even when device_add() fails? It would make more sense to add
this after the "if" statement.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
