On Wed, Oct 20, 2010 at 6:15 PM, Felipe Balbi <balbi@xxxxxx> wrote: > On Wed, Oct 20, 2010 at 09:52:06AM -0500, Felipe Contreras wrote: >> >> TWL4030_USB is inside drivers/usb/Kconfig and drivers/usb/otg/Kconfig, >> which means in order to achieve the same on the board config you would >> have to do: >> >> default y if USB_SUPPORT && (USB || USB_GADGET) && ARCH_OMAP3 >> >> Seems to be more convoluted to me. >> >> Besides, I think TWL4030_USB and the full description of it doesn't >> give any hints to the people reading drivers/usb/otg/Kconfig what is >> it used for. 'default y if ARCH_OMAP3' achieves that. > > no it doesn't. No user will 'cat drivers/usb/otg/Kconfig | grep -A 10 > TWL4030' and check the 'default y if ARCH_OMAP3 > > if you think help is not enough, fix help. Users would not need to care... if they enable USB and USB_GADGET, it will be selected automatically for OMAP3, which is what users would expect. I was talking more about developers. How should the help be fixed? "Select y if you are using an OMAP3 system that has TWL4030" >> Plus, there is no big change: >> >> config USB_MUSB_HDRC >> - Â Â Â select TWL4030_USB if MACH_OMAP_3430SDP >> >> config TWL4030_USB >> + Â Â Â default y if ARCH_OMAP3 >> > > what's the problem with: > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > index ab784bf..3af9580 100644 > --- a/arch/arm/mach-omap2/Kconfig > +++ b/arch/arm/mach-omap2/Kconfig > @@ -215,6 +215,7 @@ config MACH_NOKIA_RX51 > Â Â Â Âdepends on ARCH_OMAP3 > Â Â Â Âdefault y > Â Â Â Âselect OMAP_PACKAGE_CBB > + Â Â Â select TWL4030_USB > Âconfig MACH_OMAP_ZOOM2 > Â Â Â Âbool "OMAP3 Zoom2 board" > 1) Do you think all the OMAP3 boards should add that? 2) What if you don't want to use USB? -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
