On Tue, Oct 19, 2010 at 2:16 PM, Felipe Balbi <balbi@xxxxxx> wrote: > On Tue, Oct 19, 2010 at 05:59:58AM -0500, Felipe Contreras wrote: >> >> The USB_MUSB_HDRC dependency on NOP_USB_XCEIV || TWL4030_USB is >> already there, I'm just making it explicit. The rest are not >> dependencies, just sensible defaults, and they are already in >> drivers/usb/musb/Kconfig, I'm just moving them. > > might be true, but what will happen is that other developers will just > "follow what's in the tree" so they'll keep on adding more and more > "sesible defaults" to this line. That is actually the intention. > Linus had some really good comments about Kconfig usage some time ago > and I'm sure he wouldn't like us adding "sensible defaults" all over the > place. It's the other way around. He wanted to get rid of defconfigs completely by moving the complexity to Kconfigs: http://article.gmane.org/gmane.linux.kernel/994720 http://article.gmane.org/gmane.linux.kernel/994706 http://article.gmane.org/gmane.linux.kernel/994718 You seem to be pushing for the exact opposite; keep the complexity on the defconfigs and the burden on the user creating configs. >> If you have a better approach to avoid manually selecting TWL4030_USB >> on defconfigs, and making sure USB_MUSB_HDRC works, please share it. > > that's the thing. Currently, I don't think it should be automatic as we > can only have one transceiver structure. Look into > drivers/usb/otg/otg.c, it's just a static global pointer on that file, > which prevents us from having a working solution if you enable more than > one transceiver. > > Ideally there would be a class or something similar to allow us to > register N transceiver and use the correct one in runtime, that would > make distro-makers' life easier. It'll probably help Linaro also at some > point, but as of today, enabling more than one transceiver will never > work. Ok. But for now 'default y if ARCH_OMAP3' for TWL4030_USB doesn't hurt, nor increases the total size of Kconfigs, and solves a real problem. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
