Alan Stern a écrit :
On Mon, 6 Sep 2010, Matthieu CASTET wrote:
This looks like several different patches all rolled up into one. The
patch description mentions two different things, and there are also
those hcd->has_tt changes which aren't described at all.
We need all of them to work :
before setup, the controller could be in idle/host/device state.
ehci_halt work only when the controller is in host mode, so we need to
setup mode before ehci_halt.
Need need to move hcd->has_tt up in order ehci_halt can use it.
Note that after this patch orion/ixp4xx setup that does :
ehci_reset
(ehci_halt)
ehci_init
could be rewrite to do the correct sequence.
The name "tdi_is_ehci" is confusing. Besides being very similar to
"ehci_is_TDI", its meaning isn't clear. What other mode besides EHCI
could the TDI/ARC hardware be in? Should the name be something more
like "tdi_in_host_mode"?
Yes
Is that better ?
Yes, this is much better. Thank you.
Alan, do you know the status of this patch ?
Is it queued somewhere ?
Matthieu
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
