Re: [PATCH] USB: accept some invalid ep0-maxpacket values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 14, 2010 at 03:25:21PM -0400, Alan Stern wrote:
> A few devices (such as the RCA VR5220 voice recorder) are so
> non-compliant with the USB spec that they have invalid maxpacket sizes
> for endpoint 0.  Nevertheless, as long as we can safely use them, we
> may as well do so.
> 
> This patch (as1432) softens our acceptance criterion by allowing
> high-speed devices to have ep0-maxpacket sizes other than 64.  A
> warning is printed in the system log when this happens, and the
> existing error message is clarified.
> 
> Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Reported-by: James <bjlockie@xxxxxxxxx>
> 
> ---
> 
> Greg:
> 
> This doesn't fix a bug, since the device in question is not compliant 
> with the spec.  On the other hand I don't see how it could introduce 
> any poblems, and Windows already works with this device.
> 
> It's up to you whether or not to queue this for the -stable kernels.

I will queue it up there, as "making a device work that works with other
operating systems" is a bugfix in my mind.

thanks for the patch, and all of your work on this kind of stuff,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux