On Tue, 12 Oct 2010, Brokhman Tatyana wrote: > Hi Alan > > Thanks you for your comments. Please see my reply inline. > > In addition, I suspect the dummy_hcd driver structure shouldn't contain > > an address_device entry. It should be present only in dummy_ss_hcd. > > I'm not sure I follow... > According to the code and comments in hub.c address_device cb is used if > the host controller wishes to choose the device address itself instead of > the address chosen by the core. Correct. > It seems to me that there is nothing > preventing the dummy_hcd from supplying such cb as well. Is there? > Having both HS and SS dummy_hcd determine the device address seems more > convenient for testing proposes. For testing purposes, it is best to imitate the behavior of a real device as closely as possible. USB-2.0 host controllers do not assign their own addresses to devices; they use the addresses provided by usbcore. I think this is also true for the low/full/high-speed components of a USB-3.0 controller. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html