On Tue, Oct 12, 2010 at 7:20 AM, Ming Lei <tom.leiming@xxxxxxxxx> wrote: > Hi, > > 2010/9/29 <tom.leiming@xxxxxxxxx>: >> From: Ming Lei <tom.leiming@xxxxxxxxx> >> >> Commit 9f445cb29918dc488b7a9a92ef018599cce33df7[USB: musb: disable >> double buffering for older RTL versions] tries to disable double >> buffer mode by writing endpoint hw max packet size to TXMAP/RXMAP. >> >> First this way taken is very wrong, which can break full speed mode >> and cause overflow problem, and we should always set this registers >> by the actual max packet size from endpoint descriptor. >> >> Secondly, I have fixed the double buffer mode problem already in the >> previous patchset, and found the problem of 'infinite hangs or data >> corruption' decribled in Commit 9f445cb29918dc488b7a9a92ef018599cce33df7 >> is caused by musb gadget driver, nothing to do with older RTL chip. >> My beagle B5 uses RTL 1.4 musb IP core, but either g_file_storage/g_ether >> /g_zero can work well in double buffer mode. >> >> So, fix the problem by always using actual max packet size from endpoint >> descriptor to config TXMAP/RXMAP. >> >> Cc: Cliff Cai <cliff.cai@xxxxxxxxxx> >> Cc: Felipe Balbi <balbi@xxxxxx> >> Cc: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> >> Cc: Anand Gadiyar <gadiyar@xxxxxx> >> Cc: Mike Frysinger <vapier@xxxxxxxxxx> >> Cc: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> >> Cc: stable@xxxxxxxxxx >> Signed-off-by: Ming Lei <tom.leiming@xxxxxxxxx> >> --- >> This one is against musb-next branch of Felipe's tree. >> --- >> drivers/usb/musb/musb_gadget.c | 13 +++---------- >> 1 files changed, 3 insertions(+), 10 deletions(-) > > Grazvydas, since the patch has fixed your 'ep2in overflow' issue > of g_zero as discussed in the link below: > > http://marc.info/?t=128640815600002&r=1&w=2 > > Care to add 'Tested-by: Grazvydas Ignotas <notasas@xxxxxxxxx>' > to the patch? Sure: Tested-by: Grazvydas Ignotas <notasas@xxxxxxxxx> without this I have to keep replugging the cable for g_ether or g_cdc to start to work. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
