On Sun, 10 Oct 2010, Tatyana Brokhman wrote: > USB 3.0 hub includes 2 hubs - HS and SS ones. > Thus, when dummy_hcd enabled it will register 2 root hubs (SS and HS). > > Signed-off-by: Tatyana Brokhman <tlinder@xxxxxxxxxxxxxx> > --- > drivers/usb/gadget/dummy_hcd.c | 739 +++++++++++++++++++++++++++++++++------- > 1 files changed, 616 insertions(+), 123 deletions(-) I'd appreciate if you break this up into two patches. Separating out handle_control_request into a separate function is independent of the USB-3.0 conversion. Also, you should update the kerneldoc title line for handle_control_request: the format is wrong and it contains a spelling error. (The format of the kerneldoc for the other new routines in this patch is also wrong.) In addition, I suspect the dummy_hcd driver structure shouldn't contain an address_device entry. It should be present only in dummy_ss_hcd. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
