Re: [PATCH 2/2] Add UAS driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Matthew Wilcox wrote:
> On Tue, Sep 28, 2010 at 03:13:53PM +0200, Oliver Neukum wrote:
> > Am Dienstag, 28. September 2010, 12:14:56 schrieb Matthew Wilcox:

> > > +	cmnd->result = sense_iu->status;
> > > +	if (sdev->current_cmnd)
> > > +		sdev->current_cmnd = NULL;
> > 
> > the condition is absolutely senseless
> 
> That's not true.  Avoiding dirtying a cacheline is important for
> performance.

Go and tell your processor division to only mark a cacheline as dirty if it 
was actually changed by a write. They are throwing so much resources on things 
like SSE9 and the hell that they can probably afford doing that sort of 
optimizations. Or they already do and this condition is absolutely senseless 
;)

Eike

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux