RE: [PATCH v4] usb: musb: Adding names for IRQs in resource structure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 

>-----Original Message-----
>From: Balbi, Felipe 
>Sent: Wednesday, September 29, 2010 3:41 PM
>To: Kalliguddi, Hema
>Cc: Balbi, Felipe; linux-omap@xxxxxxxxxxxxxxx; 
>linux-usb@xxxxxxxxxxxxxxx; Tony Lindgren; Kevin Hilman; 
>Cousson, Benoit; Paul Walmsley; Mike Frysinger
>Subject: Re: [PATCH v4] usb: musb: Adding names for IRQs in 
>resource structure
>
>On Wed, Sep 29, 2010 at 03:54:45AM -0500, Kalliguddi, Hema wrote:
>> Hi,
>>
>>>-----Original Message-----
>>>From: Balbi, Felipe
>>>Sent: Wednesday, September 29, 2010 12:30 PM
>>>To: Kalliguddi, Hema
>>>Cc: linux-omap@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx;
>>>Balbi, Felipe; Tony Lindgren; Kevin Hilman; Cousson, Benoit;
>>>Paul Walmsley; Mike Frysinger
>>>Subject: Re: [PATCH v4] usb: musb: Adding names for IRQs in
>>>resource structure
>>>
>>>Hi,
>>>
>>>On Wed, Sep 29, 2010 at 11:26:39AM -0500, Kalliguddi, Hema wrote:
>>>>Index: linux-omap-pm/arch/arm/mach-davinci/usb.c
>>>>===================================================================
>>>>--- linux-omap-pm.orig/arch/arm/mach-davinci/usb.c
>>>>+++ linux-omap-pm/arch/arm/mach-davinci/usb.c
>>>>@@ -64,10 +64,12 @@ static struct resource usb_resources[] =
>>>> 	{
>>>> 		.start          = IRQ_USBINT,
>>>> 		.flags          = IORESOURCE_IRQ,
>>>>+		.name		= "mc"
>>>> 	},
>>>> 	{
>>>> 		/* placeholder for the dedicated CPPI IRQ */
>>>> 		.flags          = IORESOURCE_IRQ,
>>>>+		.name		= "dma"
>>>> 	},
>>>> };
>>>
>>>you add names only to the IRQs, this will still require the 
>memory base
>>>to be the first resource. Maybe adding a name like "regs" to 
>the memory
>>>base and changing to platform_get_resource_byname(pdev, "regs") on
>>>musb-core.c
>>>
>>It does not mandate the base address to be the first 
>resource, as the api
>>used for getting the base address takes the resource type as 
>parameter.
>>"platform_get_resource(struct platform_device *dev,unsigned int type,
>>unsigned int num)". but it mandates the base addresses have to be in
>>certain order if there are multiple base address.Since for musb there
>>is one base address.
>
>true :-p Sorry about that. Just noise.
>
That's Ok...
>-- 
>balbi
>--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux