On Tue, Sep 28, 2010 at 08:54:13PM -0400, Matthew Wilcox wrote: > > [Could you trim a little when replying?] > > On Tue, Sep 28, 2010 at 03:13:53PM +0200, Oliver Neukum wrote: > > Am Dienstag, 28. September 2010, 12:14:56 schrieb Matthew Wilcox: > > > + usb_free_streams(intf, eps, 3, GFP_KERNEL); > > > > This implies that this can fail due to a lack of memory. > > Then what? > > Uhh. I think I'll have to get Sarah to answer that question. We probably > end up resetting the endpoints instead of telling the endpoint to stop > doing streams. Sorry Oliver, the usb_free_streams() calls into the xHCI driver, which doesn't actually do anything with the memory flags. Alan Stern already noted it should be removed. Freeing streams doesn't rely on memory allocation (a command is pre-allocated when streams are enabled, and a TRB is reserved on the command ring). Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
