Hi, >-----Original Message----- >From: vapier.adi@xxxxxxxxx [mailto:vapier.adi@xxxxxxxxx] On >Behalf Of Mike Frysinger >Sent: Wednesday, September 29, 2010 3:18 AM >To: Paul Walmsley >Cc: Kalliguddi, Hema; linux-omap@xxxxxxxxxxxxxxx; >linux-usb@xxxxxxxxxxxxxxx; Balbi, Felipe; Tony Lindgren; Kevin >Hilman; Cousson, Benoit >Subject: Re: [PATCH 1/9 v3] usb: musb: Adding names for IRQs >in resource structure > >On Tue, Sep 28, 2010 at 17:44, Paul Walmsley wrote: >> On Tue, 28 Sep 2010, Mike Frysinger wrote: >>> On Tue, Sep 28, 2010 at 17:18, Paul Walmsley wrote: >>> > On Tue, 28 Sep 2010, Mike Frysinger wrote: >>> >> well, currently, your resource definition must always be >in the order >>> >> of dev int and then dma int. if it isnt, then i dont >think musb is >>> >> going to work. >>> >> >>> >> not sure why you wouldnt simply change your platform resources to >>> >> match the what the driver expects ... >>> > >>> > The resource data is getting automatically populated from >a set of data >>> > generated from TI's hardware database for the OMAP >platform, at least. >>> > While we could hack in some exceptions to that tool to >generate resources >>> > in a specific order, it seems less fragile to use the >resource name >>> > instead. That way, no matter what order the resources >are generated, the >>> > driver should still work. >>> >>> guessing you're not referring to a device tree setup, but something >>> even more convoluted ? >> >> No need to disparage it before you've seen it :-) > >ah, but that's when i do my best work > >>> i'd highly suggest that this patch be resent with the info >you've just >>> provided in its changelog so people can get a better >understanding of >>> the "why" ... i'm not against the patch, it just seemed to >be lacking >>> any background info >> >> Hema, would you care to update the patch changelog accordingly? > >i'll pre-ack that for the Blackfin changes ... or, if you split those >out, i can merge it separately for 2.6.37. I will repost the patches today for blackfin and omap changes with the changelog updated accordingly. >-mike >-- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
