On Tue, Sep 28, 2010 at 12:55:32PM +0200, Michal Nazarewicz wrote:
> From: Michal Nazarewicz <mina86@xxxxxxxxxx>
>
> This commit changes storage_common.c and file_storage.c to
> reuse definitions from linux/usb/storage.h header file.
Awesome; I didn't notice the definitions over here. That reinforces
that this is the right decision.
The only thing is that I like your names better than I like the libusual
names. I didn't change the libusual names because I didn't want to make
a big patch. So instead of this patch, could we add your names to the
usb/storage.h header file, and then convert libusual to use your names?
> @@ -157,19 +158,6 @@
> #define TYPE_DISK 0x00
> #define TYPE_CDROM 0x05
These look suspiciously like definitions available in include/scsi/scsi.h
> @@ -408,8 +396,8 @@ fsg_intf_desc = {
>
> .bNumEndpoints = 2, /* Adjusted during fsg_bind() */
> .bInterfaceClass = USB_CLASS_MASS_STORAGE,
> - .bInterfaceSubClass = USB_SC_SCSI, /* Adjusted during fsg_bind() */
> - .bInterfaceProtocol = USB_PR_BULK, /* Adjusted during fsg_bind() */
> + .bInterfaceSubClass = US_SC_SCSI, /* Adjusted during fsg_bind() */
> + .bInterfaceProtocol = US_PR_BULK, /* Adjusted during fsg_bind() */
> .iInterface = FSG_STRING_INTERFACE,
Would you (or anybody else) be interested in adding UAS support to the
gadget driver? It'd be cool to have another device available. I'd be
interested in helping / advising. I don't know if there are any USB 3
gadgets available right now, but we could implement the USB 2 version
of the protocol.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
