On Tue, Sep 28, 2010 at 12:25:56AM -0700, Greg KH wrote: > On Tue, Sep 28, 2010 at 03:17:11AM -0400, Matthew Wilcox wrote: > > On Tue, Sep 28, 2010 at 12:06:13AM -0700, Greg KH wrote: > > > > I don't intend to add 0xaa to a header file ... I see its inclusion in > > > > this driver as a temporary thing, and I'd rather remove support for it > > > > than add it to a header. > > > > > > I'm afraid to ask what the 0xaa is, but here goes, what is it? > > > > It's a prototype device that has the wrong protocol ID. Eventually I'll > > just drop support for it from the driver, but it's a useful device > > to keep testing with for the moment (it supports some aspects of the > > protocol that other devices I have access to don't). > > > > Since nobody else is likely to have one, I'd rather take the line out > > of the in-tree driver and patch it back in locally, than I would add it > > to the header file. > > Ok, that sounds good to me. Sorry, bad jetlag. You can leave it as-is for now and send me patches afterward. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
