Re: [PATCH] UAS driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 28, 2010 at 01:07:34AM -0400, Matthew Wilcox wrote:
> +static struct usb_device_id uas_usb_ids[] = {
> +	{ USB_INTERFACE_INFO(8, 6, 0x50) },
> +	{ USB_INTERFACE_INFO(8, 6, 0x62) },
> +	{ USB_INTERFACE_INFO(8, 6, 0xaa) }, /* A prototype */
> +	{ }

Don't we have the proper #defines in the usb/ch9.h file that you can use
here?  If not, please add them so that we don't have "magic" numbers.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux