On Tue, Sep 28, 2010 at 12:57:32AM -0400, Matthew Wilcox wrote: > > If I unplug a device while the UAS driver is loaded, I get an oops > in usb_free_streams(). This is because usb_unbind_interface() calls > usb_disable_interface() which calls usb_disable_endpoint() which sets > ep_out and ep_in to NULL. Then the UAS driver calls usb_pipe_endpoint() > which returns a NULL pointer and passes an array of NULL pointers to > usb_free_streams(). > > I think the correct fix for this is to check for the NULL pointer > in usb_free_streams() rather than making the driver check for this > situation. My original patch for this checked for dev->state == > USB_STATE_NOTATTACHED, but the call to usb_disable_interface() is > conditional, so not all drivers would want this check. > > [This should probably go into Sarah's xhci tree, not directly into Greg's > usb tree] Why? Does Sarah have paches that I currently don't? I thought we were synced up now. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
