Re: [PATCH 3/3] USB: cdc.h: ncm: add missed constants and structures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

>>>>> "eAO" == ext Alexey ORISHKO writes:

 > > > > +/* 32-bit NCM Datagram Pointer Entry */ struct usb_cdc_ncm_dpe32 {
 > > > > +       __le32  wDatagramIndex;
 > > > > +       __le32  wDatagramLength;
 > > > > +} __attribute__((__packed__));
 > > > > +
 > > >
 > > > We did review of the posted patch and it looks good.
 > > >
 > > > Some minor fix is needed: structure field names should reflect 32 bit
 > > size:
 > > > dwDatagramIndex
 > > > dwDatagramLength
 > > 
 > > Is that what the USB spec says?

 > Yes, see ch. 3.3.2; both index and length sizes are 4 bytes in 32-bit
 > NCM Datagram Pointer Entry.

Well, you know why it happend ;) Sorry, my fault, should check more
carefully.

>>>>> "eGK" == ext Greg KH writes:

 > Ah, ok, care to send a followup patch to fix this up?

sure. It's too late to replace the patch, I guess?

-- 
WBR, Yauheni Kaliuta
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux