On Wed, Sep 22, 2010 at 05:12:09PM +0200, Alexey ORISHKO wrote:
> On Mon, Sep 20, 2010 at 4:40 PM, <yauheni.kaliuta@xxxxxxxxx> wrote:
> > From: Yauheni Kaliuta <yauheni.kaliuta@xxxxxxxxx>
> >
> > Make a dedicated structure for datagram pointer entry. There is no
> > explicit declaration in the spec, but it's used by the host
> > implementation and makes the structure more clear.
> >
> > Add some missed constants from the spec
> >
> > Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@xxxxxxxxx>
> > ---
> > include/linux/usb/cdc.h | 57
>
> ...
>
> > +/* 32-bit NCM Datagram Pointer Entry */ struct usb_cdc_ncm_dpe32 {
> > + __le32 wDatagramIndex;
> > + __le32 wDatagramLength;
> > +} __attribute__((__packed__));
> > +
>
> We did review of the posted patch and it looks good.
>
> Some minor fix is needed: structure field names should reflect 32 bit size:
> dwDatagramIndex
> dwDatagramLength
Is that what the USB spec says?
> Hope, we could get this patch in the mainstream soon :-)
It's in my tree for the merge for .37.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
