On Wed, Sep 22, 2010 at 05:55:53PM +0200, Alexey ORISHKO wrote: > > -----Original Message----- > > From: Greg KH [mailto:greg@xxxxxxxxx] > > Sent: Wednesday, September 22, 2010 7:39 PM > > To: Alexey ORISHKO > > Cc: Yauheni.Kaliuta@xxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; Hans Petter > > SELASKY > > Subject: Re: [PATCH 3/3] USB: cdc.h: ncm: add missed constants and > > structures > > > > On Wed, Sep 22, 2010 at 05:12:09PM +0200, Alexey ORISHKO wrote: > > > On Mon, Sep 20, 2010 at 4:40 PM, <yauheni.kaliuta@xxxxxxxxx> wrote: > > > > From: Yauheni Kaliuta <yauheni.kaliuta@xxxxxxxxx> > > > > > > > > Make a dedicated structure for datagram pointer entry. There is no > > > > explicit declaration in the spec, but it's used by the host > > > > implementation and makes the structure more clear. > > > > > > > > Add some missed constants from the spec > > > > > > > > Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@xxxxxxxxx> > > > > --- > > > > include/linux/usb/cdc.h | 57 > > > > > > ... > > > > > > > +/* 32-bit NCM Datagram Pointer Entry */ struct usb_cdc_ncm_dpe32 { > > > > + __le32 wDatagramIndex; > > > > + __le32 wDatagramLength; > > > > +} __attribute__((__packed__)); > > > > + > > > > > > We did review of the posted patch and it looks good. > > > > > > Some minor fix is needed: structure field names should reflect 32 bit > > size: > > > dwDatagramIndex > > > dwDatagramLength > > > > Is that what the USB spec says? > > Yes, see ch. 3.3.2; both index and length sizes are 4 bytes in 32-bit NCM Datagram Pointer Entry. chapter 3.3.2 in what spec? Note, we only use the "hungarian" notation for when the USB specification requires it on the name of the fields, we don't add it for our own variables as that's not the Linux style. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
