Hello. On Wednesday 22 September 2010 02:39:08 pm Felipe Balbi wrote: > >>> musb_g_rx() always returns if next_request() call yields NULL, so the DBG() > >>> near the function's end can never be invoked. Remove it along with unneeded > >>> 'return'; also remove the duplicate 'request' check... > >>> Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> > >> applied, thanks > > Unfortunately, I stupidly forgot to remove the pointless *if* itself, so > >there's gonna be v3 today. :-< > if you send me incremental diff, I can amend. OK, here you are: diff -u linux-2.6/drivers/usb/musb/musb_gadget.c linux-2.6/drivers/usb/musb/musb_gadget.c --- linux-2.6/drivers/usb/musb/musb_gadget.c +++ linux-2.6/drivers/usb/musb/musb_gadget.c @@ -822,9 +822,8 @@ return; } - /* analyze request if the ep is hot */ - if (request) - rxstate(musb, to_musb_request(request)); + /* Analyze request */ + rxstate(musb, to_musb_request(request)); } /* ------------------------------------------------------------ */ WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
