Re: [PATCH v2 2/2] musb_gadget: kill unreachable code in musb_g_rx()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 22, 2010 at 04:59:44AM -0500, Sergei Shtylyov wrote:
On 22-09-2010 13:24, Felipe Balbi wrote:

musb_g_rx() always returns if next_request() call yields NULL, so the DBG()
near the function's end can never be invoked. Remove it along with unneeded
'return'; also remove the duplicate 'request' check...

Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>

applied, thanks

   Unfortunately, I stupidly forgot to remove the pointless *if* itself, so
there's gonna be v3 today. :-<

if you send me incremental diff, I can amend.

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux