Re: [RFC/PATCH] usb: musb: split out hw glue layer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/9/16 Felipe Balbi <balbi@xxxxxx>:
> split hw glue layer to its own platform_device,
> which is a parent of musb-hdrc platform_device.
>
> we can now handle suspend/resume, PM, clocks
> and context save/restore in a better and local

Seems context save/restore is kind of common operation,
which may access most of the common register defined in
musb spec, so could we keep or refactor it as common
functions in musb_core to avoid duplicated implementations
in each hw glue layer?

Also, for other handlers, if possible, we should refactor
the common operation into musb_core and let hw gule layer
to implement its own differences only.

I don't think the implement in this patch is good since it
simply removes this functions and let all hw glue to
reimplement them again, this way may lead to much
duplicated code in each hw glue layer.

> fashion which won't touch other archs.


-- 
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux