Alan Stern a écrit :
On Tue, 14 Sep 2010, Pavan Kondeti wrote:
Maybe you can simply remove the ehci_reset call from ehci_run. I don't
see any reason why it is needed there.
This is better than introducing another callback. The rule is that HCD must ensure
controller is reset before ->start method is called.
But if you do then you will have to add calls to ehci_reset in drivers
like ehci-au1xxx, ehci-omap, and ehci-w90x900, which otherwise wouldn't
call it.
ehci-orion HCD calls ehci_halt after ehci_reset in ->reset method. This should
also be fixed before removing ehci_reset from ehci_run(). Right?
I don't know... it seems harmless. There's no obvious reason why it's
there, but it doesn't hurt anything.
It is only harmless if you apply my "[PATCH] ehci tdi : let's tdi_reset
set host mode" [1].
It is a tdi device.
May be with this patch, tdi_reset can be put in platform driver instead
of ehci_reset ?
Matthieu
[1]
We need all of them to work :
before setup, the controller could be in idle/host/device state.
ehci_halt work only when the controller is in host mode, so we need to
setup mode before ehci_halt.
Need need to move hcd->has_tt up in order ehci_halt can use it.
Note that after this patch orion/ixp4xx setup that does :
ehci_reset
(ehci_halt)
ehci_init
could be rewrite to do the correct sequence.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
