On Tue, 14 Sep 2010, Pavan Kondeti wrote: > > Maybe you can simply remove the ehci_reset call from ehci_run. I don't > > see any reason why it is needed there. > > > This is better than introducing another callback. The rule is that HCD must ensure > controller is reset before ->start method is called. > > > But if you do then you will have to add calls to ehci_reset in drivers > > like ehci-au1xxx, ehci-omap, and ehci-w90x900, which otherwise wouldn't > > call it. > > > ehci-orion HCD calls ehci_halt after ehci_reset in ->reset method. This should > also be fixed before removing ehci_reset from ehci_run(). Right? I don't know... it seems harmless. There's no obvious reason why it's there, but it doesn't hurt anything. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
