On Tue, August 31, 2010 07:41, Clemens Ladisch wrote: > Simon Arlott wrote: >> Commit f661c6f8c67bd55e93348f160d590ff9edf08904 adds a check of the pipe type if >> CONFIG_USB_DEBUG is enabled, > > I didn't see that commit last year, but wouldn't it break devices like > the ESI MIDI Mate whose descriptors want to have low-speed bulk transfers > and where the driver has to submit interrupt transfers instead to get it > to work at all? If the transfer type doesn't match the pipe type then yes, but only when CONFIG_USB_DEBUG is enabled. Perhaps these need to be moved to a CONFIG_USB_STRICT. Having a "debug" mode change the behaviour is not a good idea, but some of the code in that ifdef has been there since the import to git. Regardless of which configuration option enables it, the pipe type check needs an error message to explain why the driver received -EPIPE. -- Simon Arlott -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
