Re: [PATCH 1/2] USB: musb: fix kernel panic if using out ep with FIFO_TXRX style(v1)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/8/30 Greg KH <greg@xxxxxxxxx>:
> On Mon, Aug 30, 2010 at 04:19:35PM +0800, Ming Lei wrote:
>> 2010/8/3  <tom.leiming@xxxxxxxxx>:
>> > From: Ming Lei <tom.leiming@xxxxxxxxx>
>> >
>> > For shared fifo hw endpoint(with FIFO_TXRX style), only ep_in
>> > field of musb_hw_ep is intialized in musb_g_init_endpoints, and
>> > ep_out is not initialized, but musb_g_rx and rxstate may access
>> > ep_out field of musb_hw_ep by the method below:
>> >
>> > ? ? ? ?musb_ep = &musb->endpoints[epnum].ep_out
>> >
>> > which can cause the kernel panic[1] below, this patch fixes the issue
>> > by getting 'musb_ep' from '&musb->endpoints[epnum].ep_in' for shared fifo
>> > endpoint.
>>
>> Greg, could you queue this patch into your tree since it has
>> been reviewed by Sergei and other guys have no objections?
>>
>> I have other patches which may depend this one.
>
> For this, and your other musb patch, I need to see Felipe ack them
> before I will take them as he is the musb maintainer.

I see.

Felipe, could you give your comments on this musb patches?


thanks,

-- 
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux