Re: [PATCH] USB: musb: move musb debugfs entry under usb debugfs root dir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 27, 2010 at 10:34:45PM +0530, Gadiyar, Anand wrote:
> tom.leiming@xxxxxxxxx wrote:
> > 
> > From: Ming Lei <tom.leiming@xxxxxxxxx>
> > 
> > All hcd's debugfs entries are under usb debugfs root dir already,
> > so musb should not be a exception.
> > 
> > Signed-off-by: Ming Lei <tom.leiming@xxxxxxxxx>
> > ---
> >  drivers/usb/musb/musb_debugfs.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/usb/musb/musb_debugfs.c b/drivers/usb/musb/musb_debugfs.c
> > index c79a5e3..b19c31c 100644
> > --- a/drivers/usb/musb/musb_debugfs.c
> > +++ b/drivers/usb/musb/musb_debugfs.c
> > @@ -257,7 +257,7 @@ int __init musb_init_debugfs(struct musb *musb)
> >  	struct dentry		*file;
> >  	int			ret;
> >  
> > -	root = debugfs_create_dir("musb", NULL);
> > +	root = debugfs_create_dir("musb", usb_debug_root);
> >  	if (IS_ERR(root)) {
> >  		ret = PTR_ERR(root);
> >  		goto err0;
> 
> Hi,
> 
> This will not work when you do not have USB Host support enabled in
> your kernel.

Then we should move the creation of usb_debug_root out into somewhere
that will work for both types of systems, right?  Now where that might
be, I can't tell at the moment...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux