Sorry - I haven't tested the patch, it comes from here: https://bugs.edge.launchpad.net/ubuntu/+source/linux/+bug/42149 It seems to work for the original contributor. The only modification I did is to apply this change without the need to specify a module option. Thank you, Mohamed Amine IL Idrissi On Thu, Aug 26, 2010 at 2:58 PM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > On Thu, 26 Aug 2010, Mohammed Amine IL Idrissi wrote: > >> From: Mohamed Amine IL Idrissi >> Sometimes, usb devices won't be powered off at shutdown. This change >> will make it power off. > > How do you know that the devices get powered off when the patch is > applied? The fact that an LED goes out does not mean the device is > powered off. For a rigorous test you should measure the voltage on the > USB bus. > > My guess is that the devices remain powered on either way. The > difference is that with the patch the device decides to suspend, so it > turns off the LED and uses less power -- but it still uses some power. > >> Signed-off-by: Mohamed Amine IL Idrissi <ilidrissiamine@xxxxxxxxx> >> --- >> This is related to bug 16576: https://bugzilla.kernel.org/show_bug.cgi?id=16576 >> --- linux-2.6/drivers/usb/host/ohci-hcd.c.orig 2010-08-26 >> 12:58:45.978958450 +0000 >> +++ linux-2.6/drivers/usb/host/ohci-hcd.c 2010-08-26 >> 13:00:01.401898124 +0000 >> @@ -383,7 +383,7 @@ static int ohci_get_frame (struct usb_hc >> static void ohci_usb_reset (struct ohci_hcd *ohci) >> { >> ohci->hc_control = ohci_readl (ohci, &ohci->regs->control); >> - ohci->hc_control &= OHCI_CTRL_RWC; >> + ohci->hc_control &= (OHCI_CTRL_RWC | OHCI_CTRL_HCFS); >> ohci_writel (ohci, ohci->hc_control, &ohci->regs->control); >> } > > Have you tested that this works when you do rmmod ohci-hcd; modprobe > ohci-hcd? > > Also, what happens to the devices (both with and without the patch) if > you do rmmod ohci-hcd before shutting down the system? > > Alan Stern > > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
