RE: [PATCH 5/6] usb: ohci: don't hard-code TLL channel count

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



It is [PATCH 5/5] not [PATCH 5/6].
I have resent this mail with this subject correction.

Regards,
Keshava Munegowda
 
 

> -----Original Message-----
> From: Munegowda, Keshava
> Sent: Wednesday, August 18, 2010 8:26 AM
> To: linux-usb@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx
> Cc: Munegowda, Keshava; Gadiyar, Anand
> Subject: [PATCH 5/6] usb: ohci: don't hard-code TLL channel count
> 
> Make TLL channel count a parameter instead of a hardcoded value.
> This allows us to be flexible with future OMAP revisions which
> could have a different number of channels.
> 
> Signed-off-by: Keshava Munegowda <keshava_mgowda@xxxxxx>
> Signed-off-by: Anand Gadiyar <gadiyar@xxxxxx>
> ---
>  drivers/usb/host/ohci-omap3.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> Index: kernel-omap4-base/drivers/usb/host/ohci-omap3.c
> ===================================================================
> --- kernel-omap4-base.orig/drivers/usb/host/ohci-omap3.c
> +++ kernel-omap4-base/drivers/usb/host/ohci-omap3.c
> @@ -245,7 +245,8 @@ static unsigned ohci_omap3_fslsmode(enum
>  	}
>  }
> 
> -static void ohci_omap3_tll_config(struct ohci_hcd_omap3 *omap)
> +static void ohci_omap3_tll_config(struct ohci_hcd_omap3 *omap,
> +					u8 tll_channel_count)
>  {
>  	u32 reg;
>  	int i;
> @@ -263,7 +264,7 @@ static void ohci_omap3_tll_config(struct
>  	 * REVISIT: Only the 3-pin and 4-pin PHY modes have
>  	 * actually been tested.
>  	 */
> -	for (i = 0; i < OMAP_TLL_CHANNEL_COUNT; i++) {
> +	for (i = 0; i < tll_channel_count; i++) {
> 
>  		/* Enable only those channels that are actually used */
>  		if (omap->port_mode[i] == OMAP_OHCI_PORT_MODE_UNUSED)
> @@ -422,7 +423,7 @@ static int omap3_start_ohci(struct ohci_
>  	ohci_omap_writel(omap->uhh_base, OMAP_UHH_HOSTCONFIG, reg);
>  	dev_dbg(omap->dev, "UHH setup done, uhh_hostconfig=%x\n", reg);
> 
> -	ohci_omap3_tll_config(omap);
> +	ohci_omap3_tll_config(omap, OMAP_TLL_CHANNEL_COUNT);
> 
>  	return 0;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux