On Wed, 18 Aug 2010, Xu, Andiry wrote: > To remove alloc_dev method calling in usb_alloc_dev(), two more places > need to be modified: xhci_check_args() in > xhci_discover_or_reset_device(), to allow udev with slot_id = 0 to be > allocate; and reset super speed device in hub_port_init(). I tried and > it seems work fine. But I wonder if there will be any potential issue, > especially xhci_discover_or_reset_device() uses udev->slot_id to > allocate or reset device. Will there be any udev->slot_id conflict issue > in certain cases? Sarah, what's your opinion? There might be a problem if slot IDs get reused when you start reviving the devices under a controller that has been reset. The udev->slot_id value might point to another device's structure. xhci_discover_or_reset_device will have to check and make sure that the slot really does match the device. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
