On Thu, 12 Aug 2010, David Brownell wrote: > Looks OK, but I can't test or give it > a detailed review just now. An ACK from > Alan would be nice. There's nothing obviously wrong with this change. However based on all the preceding discussion, I now think the best approach may be _never_ to make up a fake serial number. Use the module parameter, if any, and otherwise issue a warning and don't have a serial number string descriptor (even though that violates the spec). At this point it should be easy to write a patch to implement and document the new behavior, for both file-storage and mass-storage. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html