On Wed, Aug 11, 2010 at 05:50:49PM +0800, Xu, Andiry wrote: > > -----Original Message----- > > From: Sarah Sharp [mailto:sarah.a.sharp@xxxxxxxxxxxxxxx] > > Sent: Wednesday, August 11, 2010 2:17 AM > > To: Alan Stern > > Cc: Xu, Andiry; USB list; gregkh@xxxxxxx > > Subject: Re: [PATCH 0/4 v5] xHCI: PM patchset > > > > > Reinitializing the host controller is okay. In fact, you should be > > > doing that anyway if it tells you that it didn't retain its state > > > during a suspend. > > > > Sure. Andiry fixed his BIOS issue, but I'd still like to see the PM > > patches deal with this case. Andiry, perhaps you can un-fix it to > test? > > > > So do you mean the xHC controller should be re-initialized when it has > restore error? I can try it but I've got two questions: > > 1. EHCI and OHCI only do a host controller reset when they lost power > during resume. Does xHCI need to be re-initialized? I think so, but I'd have to check the xHCI specification. > 2. Does xHC re-initialization helps to resolve the device address > conflict issue? I assume it comes from the xHCI specific address > assignment mechanism. It will, if you change xhci_reset_device() to reallocate the slot ID, and then change hub_port_init() to call update_address() once the new address is re-assigned. I replied to Alan Stern about that proposal yesterday. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
