Re: [patch 2/6] scsi/sr: add no_read_disc_info scsi_device flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 10, 2010 at 02:29:20PM -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> From: Hans de Goede <hdegoede@xxxxxxxxxx>
> 
> Some USB devices emulate a usb-mass-storage attached (scsi) cdrom device,
> usually this fake cdrom contains the windows software for the device. 
> While working on supporting Appotech ax3003 based photoframes, which do
> this I discovered that they will go of into lala land when ever they see a
> READ_DISC_INFO scsi command.
> 
> Thus this patch adds a scsi_device flag (which can then be set by the
> usb-storage driver through an unsual-devs entry), to indicate this, and
> makes the sr driver honor this flag.
> 
> I know this sucks, but as discussed on linux-scsi list there is no other
> way to make this device work properly.
> 
> Looking at usb traces made under windows, windows never sends a
> READ_DISC_INFO during normal interactions with a usb cdrom device.  So as
> this cdrom emulation thingie becomes more common we might see more of this
> problem.
> 
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
> Cc: Greg KH <greg@xxxxxxxxx>
> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Cc: Matthew Dharm <mdharm-usb@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
> 
>  drivers/scsi/sr.c          |    8 +++++++-
>  include/scsi/scsi_device.h |    1 +

I can't take this one (and the other scsi-only one), unless James acks
it.  If so, I'll be glad to do so.

James?

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux