On 08/03/2010 08:36 AM, Alan Stern wrote:
On Tue, 3 Aug 2010, Justin P. Mattock wrote:
On 08/03/2010 07:29 AM, Alan Stern wrote:
On Tue, 3 Aug 2010 Valdis.Kletnieks@xxxxxx wrote:
On Mon, 02 Aug 2010 21:26:28 PDT, "Justin P. Mattock" said:
diff --git a/drivers/usb/core/sysfs.c b/drivers/usb/core/sysfs.c
if (alt->string)
- retval = device_create_file(&intf->dev,&dev_attr_interface);
+ device_create_file(&intf->dev,&dev_attr_interface);
intf->sysfs_files_created = 1;
return 0;
Justin, did you try compiling your new code? Those unused values are
there because device_create_file is declared as __must_check.
I went as far as compiling, once I saw no warning then figured o.k
I'll send out what I have for feedback then go from there.
(and just for the record I want to thank those who took the time to go
through and give feedback).
It's a little surprising that you didn't get any warning. I guess you
don't have CONFIG_ENABLE_MUST_CHECK turned on.
Alan Stern
no nothing.. just the original warning.. as for MUST_CHECK
yeah your right it's off.
Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
