On Tue, Aug 03, 2010 at 11:34:26AM -0400, Alan Stern wrote: > On Tue, 3 Aug 2010 Valdis.Kletnieks@xxxxxx wrote: > > > > Failure to create a file in sysfs is almost never fatal and usually not > > > even dangerous. Ignoring the error is generally better than failing > > > the entire operation. > > > > Then why the __must_check attribute if it's usually ignorable? I thought > > that was reserved for functions that you damned sight better well check > > for errors because bad things are afoot otherwise? > > That's a good question. Perhaps Greg KH knows the answer. You should check the return value for that function. To not do that is a bug. This one looks like it snuck through. Fixing it properly is the correct thing to do. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
