> --- On Tue, 7/27/10, Michal Nazarewicz <mina86@xxxxxxx> wrote: >> Here are the changes to the composite.c: >> * https://patchwork.kernel.org/patch/113584/ David Brownell <david-b@xxxxxxxxxxx> writes: > NAK on at least this proposed change, since > non-managed serial numbers are deeply broken. >>> + str = iSerialNumber ?: "0123456789AB"; My thinking was that it's better to provide a fake serial then no serial at all. From what I've been informed Windows in some cases do not like mass storage without serial number (ignoring other LUNs). Later in the code, you'll notice that fake serial number is provided only when gadget driver explicitly state that it needs a serial number (so gadgets won't be affected unless they opt for this behaviour) and that composite will issue a warning about missing module parameter. I thought it'll be a good compromise. Still not convinced? > .. looking at the rest. Great. Waiting for your comments on the composite providing default strings if gadget didn't provide them. ;) -- Pozdrawiam _ _ .o. | Wasal Jasnie Oswieconej Pani Informatyki o' \,=./ `o ..o | Michal "mina86" Nazarewicz <mina86*tlen.pl> (o o) ooo +---<jid:mina86-jabber.org>---<tlen:mina86>---ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
