Re: [PATCH] usb: musb: tusb6010: fix n8x0_defconfig build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

Greg KH wrote:

musb_platform_{save,restore}_context are defined in musb_core.h
to be empty for this platform. Remove the additional empty
function to avoid this build break.
CC      drivers/usb/musb/tusb6010.o
drivers/usb/musb/tusb6010.c:34: error: expected identifier or '(' before 'do'
drivers/usb/musb/tusb6010.c:34: error: expected identifier or '(' before 'while'
drivers/usb/musb/tusb6010.c:39: error: expected identifier or '(' before 'do'
drivers/usb/musb/tusb6010.c:39: error: expected identifier or '(' before 'while'
Compile-tested with n8x0_defconfig.
Signed-off-by: Anand Gadiyar <gadiyar@xxxxxx>
Cc: Felipe Balbi <felipe.balbi@xxxxxxxxx>
Cc: Vincent Sanders <vince@xxxxxxxxxxxx>

  Such patch has already been submitted by Felipe himself and Greg
has even queued it:
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/usb/usb-musb-tusb6010-fix-compile-error-with-n8x0_defconfig.patch
  I'm not sure why it's not in the usb.current/ patchset though...

Good point, I'll go move it.

   Then how about these two:

usb-musb-fix-compilation-warning-in-host-only-mode.patch
usb-musb-use-correct-register-widths-in-register-dumps.patch

They can wait until .35 is out and merge with .36, right?

    Well, everything can wait. But what's the point of waiting with bug fixes?

thanks,

greg k-h

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux