RE: [PATCH 2/2] usb: ehci_omap: fix device detect issue with modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,
> On 07/07/10 21:07, Gadiyar, Anand wrote:
> > Felipe Balbi wrote:
> >
> >> On Tue, Jul 06, 2010 at 05:30:37PM +0530, Ajay Kumar Gupta wrote:
> >>
> >>> +static void omap_ehci_soft_phy_reset(struct ehci_hcd_omap *omap, u8
> port)
> >>> +{
> >>> +	unsigned reg = 0;
> >>> +
> >>> +	reg = ULPI_FUNC_CTRL_RESET | ULPI_FUNC_CTRL_SUSPENDM
> >>>
> >> suspendm should be done when we remove the driver (omap_sotp_ehc), to
> >> put transceiver is lower power mode.
> >>
> >>
> > Confused. suspendm should be automatically done by the controller, and
> > should never need to be set explicitly like this.
> >
> >
> 
> ULPI specification rev. 1.1 defines 4 types of registers: read, write,
> set and clear.
> If you use the 'set' register then the bits are OR'ed and thus you don't
> have to set
> the suspendm bit as it is set by default, but if you use the 'write'
> register,
> you can clear the suspendm bit accidentially.

We are using SET register so we need not set suspendm as '0' wouldn't have
Any affect.

Thanks,
Ajay
> 
> > - Anand
> >
> > (Wish I had access to the hardware right now...)
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> >
> 
> --
> Regards,
> Igor.

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux