RE: [PATCH 2/2] usb: ehci_omap: fix device detect issue with modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,
> > On Tue, Jul 06, 2010 at 05:30:37PM +0530, Ajay Kumar Gupta wrote:
> > > +static void omap_ehci_soft_phy_reset(struct ehci_hcd_omap *omap, u8
> port)
> > > +{
> > > +	unsigned reg = 0;
> > > +
> > > +	reg = ULPI_FUNC_CTRL_RESET | ULPI_FUNC_CTRL_SUSPENDM

ULPI_FUNCTION_CTRL_SET register says there is no effect of writing '0'
to any bit so we can drop ULPI_FUNC_CTRL_SUSPENDM here. I will update
the patches and post it.

Regards,
Ajay

> >
> > suspendm should be done when we remove the driver (omap_sotp_ehc), to
> > put transceiver is lower power mode.
> >
> 
> Confused. suspendm should be automatically done by the controller, and
> should never need to be set explicitly like this.
> 
> - Anand
> 
> (Wish I had access to the hardware right now...)
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux