On Tue, Jun 29, 2010 at 11:19:52AM +0200, stephane duverger wrote: > On Mon, 28 Jun 2010 11:13:32 -0700 > Greg KH <greg@xxxxxxxxx> wrote: > > > > +#include <linux/dma-mapping.h> > > > > Why is this change needed? > > CC arch/arm/mach-omap2/usb-ehci.o > arch/arm/mach-omap2/usb-ehci.c:264: error: implicit declaration of function ‘DMA_BIT_MASK’ > > It was a way to fix it. That sounds like a different bug/issue than this patch is supposed to support. Care to make it a separate patch? > > > +#include <linux/sched.h> > > > > Why is this needed? > > In file included from drivers/usb/gadget/dbgp.c:17: > drivers/usb/gadget/u_serial.c: In function ‘gs_start_tx’: > drivers/usb/gadget/u_serial.c:369: error: ‘TASK_INTERRUPTIBLE’ undeclared (first use in this function) > drivers/usb/gadget/u_serial.c:369: error: (Each undeclared identifier is reported only once > drivers/usb/gadget/u_serial.c:369: error: for each function it appears in.) > drivers/usb/gadget/u_serial.c: In function ‘gs_rx_push’: > drivers/usb/gadget/u_serial.c:546: error: ‘TASK_INTERRUPTIBLE’ undeclared (first use in this function) > drivers/usb/gadget/u_serial.c: In function ‘gs_close’: > drivers/usb/gadget/u_serial.c:857: error: ‘TASK_INTERRUPTIBLE’ undeclared (first use in this function) > drivers/usb/gadget/u_serial.c:857: error: implicit declaration of function ‘signal_pending’ > drivers/usb/gadget/u_serial.c:857: error: implicit declaration of function ‘schedule_timeout’ > drivers/usb/gadget/u_serial.c: In function ‘gserial_cleanup’: > drivers/usb/gadget/u_serial.c:1190: error: ‘TASK_UNINTERRUPTIBLE’ undeclared (first use in this function) > drivers/usb/gadget/u_serial.c:1190: error: implicit declaration of function ‘schedule’ > drivers/usb/gadget/u_serial.c: In function ‘gserial_disconnect’: > drivers/usb/gadget/u_serial.c:1311: error: ‘TASK_INTERRUPTIBLE’ undeclared (first use in this function) > > As previously, it was a way to fix it. Again, that looks like a different issue, not caused by your other changes, right? > I also removed the GPL part from "dbgp.c". I foolishly copied it from a usb gadget. > I just had a look into some other files in the kernel. The constant > point seems to be the copyright, the date and the name. > So these are the only things that have been left. Feel free to ask me to add/remove/atomize-myself :) > > I just sent you a patch to fix the compilation issue and a patch for > the feature. Is this right for you ? I'll take a look at it. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
