On Mon, Jun 28, 2010 at 07:10:36PM +0200, stephane duverger wrote: > diff --git a/arch/arm/mach-omap2/usb-ehci.c b/arch/arm/mach-omap2/usb-ehci.c > index c68f799..465699f 100644 > --- a/arch/arm/mach-omap2/usb-ehci.c > +++ b/arch/arm/mach-omap2/usb-ehci.c > @@ -20,6 +20,7 @@ > #include <linux/delay.h> > #include <linux/platform_device.h> > #include <linux/clk.h> > +#include <linux/dma-mapping.h> > #include <asm/io.h> > #include <plat/mux.h> > Why is this change needed? > +if USB_G_DBGP > +choice > + prompt "EHCI Debug Device mode" > + default USB_G_DBGP_SERIAL > + > +config USB_G_DBGP_PRINTK > + depends on USB_G_DBGP > + bool "printk" > + help > + Directly printk() received data. No interaction. > + > +config USB_G_DBGP_SERIAL > + depends on USB_G_DBGP > + bool "serial" > + help > + Userland can interact using /dev/ttyGSxxx. The indentation here seems a bit odd, care to fix it up? > +/* > + * dbgp.c -- EHCI Debug Port device gadget > + * > + * Copyright (C) 2010 Stephane Duverger > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. Do you really mean "any later version"? > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA These paragraphs aren't needed. > diff --git a/drivers/usb/gadget/u_serial.c b/drivers/usb/gadget/u_serial.c > index 16bdf77..a1446d2 100644 > --- a/drivers/usb/gadget/u_serial.c > +++ b/drivers/usb/gadget/u_serial.c > @@ -18,6 +18,7 @@ > /* #define VERBOSE_DEBUG */ > > #include <linux/kernel.h> > +#include <linux/sched.h> > #include <linux/interrupt.h> > #include <linux/device.h> > #include <linux/delay.h> Why is this needed? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
