Re: [PATCH] hso: remove setting of low_latency flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi all,

Did the patch below get accepted or is there a problem with it ?
Haven't seen it appearing in any git trees so far.

Thanks,

Filip-

On Fri, 2010-06-11 at 11:17 +0200, f.aben@xxxxxxxxxx wrote:
> This patch removes the setting of the low_latency flag. 
> tty_flip_buffer_push() is occasionally being called in irq context, which 
> causes a hang if the low_latency flag is set.
> Removing the low_latency flag only seems to impact the flush to ldisc, 
> which will now be put on a workqueue.
> 
> Signed-off-by: Filip Aben <f.aben@xxxxxxxxxx>
> 
> ---
> 
> diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
> index 0a3c41f..4dd2351 100644
> --- a/drivers/net/usb/hso.c
> +++ b/drivers/net/usb/hso.c
> @@ -1334,7 +1334,6 @@ static int hso_serial_open(struct tty_struct *tty, struct file *filp)
>  	/* check for port already opened, if not set the termios */
>  	serial->open_count++;
>  	if (serial->open_count == 1) {
> -		tty->low_latency = 1;
>  		serial->rx_state = RX_IDLE;
>  		/* Force default termio settings */
>  		_hso_serial_set_termios(tty, NULL);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux