Re: [PATCH 2/3] EHCI: EHCI 1.1 addendum: Basic LPM feature support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Donnerstag, 3. Juni 2010 05:46:41 schrieb Du, Alek:
> >> >> >
> >> >> >No. Please make an explicit hook for this in usbcore.
> >> >>
> >> >> Thanks, but I do not know if we can make it ehci specific?
> >> >
> >> >Does anything but a subset of EHCI support LPM?
> >> >I am not sure that I understand the question.
> >>
> >> What I mean is, I do not want to touch usb core code, since it is only a EHCI
> >feature.
> >> If we could keep the patch only in EHCI part, it is good.
> >
> >If you put it into the reset_device method of EHCI, all will be well, won't it?
> >
> >	Regards
> >		Oliver
> 
> The problem is during reset_device, the address of the device is unknown, while
> we need fill the address in PORTSC register to enable LPM ... like:
> 
> ehci_lpm_set_da(..., dev_address ... )
> 
> Maybe we need to define a set_address callback hook in hcd ? or keep current "ugly" way?

I see. In this case an additional callback is needed. We have them for USB 3.0
all over the place. This is no problem.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux