David Brownell wrote: > > > > >"incompatible Kconfig role setting" > > > > there's a patch making that a warning instead of an #error > > if I'm not wrong. > > It's not an #error, it's a dev_err(). > > But more to the point, it's reporting a real error. As > the comment in the code explains: > > /* The driver might handle more features than > * the board; OK. > * Fail when the board needs a feature that's > * not enabled. > */ > > Ut;s simple: OTG connectors require OTG support. Host > connectors require host support. Peripheral connectors > require peripheral support. Why is anyone confused?? A board which has an OTG connector, and supports OTG mode with this driver, very likely also supports host-only and peripheral-only usage on that port. Many times, we build kernels without USB host support or without USB gadget support compiled in (if only for testing). Instead of failing init, wouldn't it be useful to report a big warning and downgrading to host-only or peripheral-only roles as configured in the kernel? (which is almost what Ming Lei's patch at [1] does - except that it uses dev_info instead of something more severe). (Okay, I do know anyone who compiles a custom kernel of this sort is likely capable of patching the board files as needed to downgrade to the desired mode. But I still think the patch at [1] is useful to have.) - Anand [1] <http://marc.info/?l=linux-usb&m=127367875600618&w=2> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
