On Thu, May 27, 2010 at 09:32:13AM +0300, Igor Grinberg wrote:
> otg_io_write() function does not follow the declaration of
> struct otg_io_access_ops.
>
> Signed-off-by: Igor Grinberg <grinberg@xxxxxxxxxxxxxx>
> ---
> include/linux/usb/otg.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/usb/otg.h b/include/linux/usb/otg.h
> index f8302d0..54b2c5e 100644
> --- a/include/linux/usb/otg.h
> +++ b/include/linux/usb/otg.h
> @@ -146,10 +146,10 @@ static inline int otg_io_read(struct otg_transceiver *otg, u32 reg)
> return -EINVAL;
> }
>
> -static inline int otg_io_write(struct otg_transceiver *otg, u32 reg, u32 val)
> +static inline int otg_io_write(struct otg_transceiver *otg, u32 val, u32 reg)
> {
> if (otg->io_ops && otg->io_ops->write)
> - return otg->io_ops->write(otg, reg, val);
> + return otg->io_ops->write(otg, val, reg);
Heh, it was buggy, but worked :)
I'll queue this up, nice catch.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
