Sergei Shtylyov wrote:
> Sent: Thursday, May 20, 2010 11:03 PM
> To: linux-usb@xxxxxxxxxxxxxxx; felipe.balbi@xxxxxxxxx
> Cc: gregkh@xxxxxxx; davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx; stable@xxxxxxxxxx
> Subject: [PATCH resend] musb_core: make disconnect and suspend interrupts work again
>
> Commit 1c25fda4a09e8229800979986ef399401053b46e (usb: musb: handle irqs in the
> order dictated by programming guide) forgot to get rid of the old 'STAGE0_MASK'
> filter for calling musb_stage_orq(), so now disconnect and suspend interrupts
> are effectively ignored...
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxx
>
Thanks for fixing this. I see the behavior with current mainline
on my OMAP3 boards.
Acked-by: Anand Gadiyar <gadiyar@xxxxxx>
> ---
> The patch is against the recent Linus' tree.
> Should be applied to 2.6.34.y as well...
> Resending with the correct subject. :-/
>
> drivers/usb/musb/musb_core.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> Index: linux-2.6/drivers/usb/musb/musb_core.c
> ===================================================================
> --- linux-2.6.orig/drivers/usb/musb/musb_core.c
> +++ linux-2.6/drivers/usb/musb/musb_core.c
> @@ -371,10 +371,6 @@ void musb_hnp_stop(struct musb *musb)
> * @param power
> */
>
> -#define STAGE0_MASK (MUSB_INTR_RESUME | MUSB_INTR_SESSREQ \
> - | MUSB_INTR_VBUSERROR | MUSB_INTR_CONNECT \
> - | MUSB_INTR_RESET)
> -
> static irqreturn_t musb_stage0_irq(struct musb *musb, u8 int_usb,
> u8 devctl, u8 power)
> {
> @@ -1519,7 +1515,7 @@ irqreturn_t musb_interrupt(struct musb *
> /* the core can interrupt us for multiple reasons; docs have
> * a generic interrupt flowchart to follow
> */
> - if (musb->int_usb & STAGE0_MASK)
> + if (musb->int_usb)
> retval |= musb_stage0_irq(musb, musb->int_usb,
> devctl, power);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
