Hello.
Greg KH wrote:
+ temp = xhci_readl(xhci, &xhci->op_regs->command);
+ temp |= (CMD_RUN);
Useless parens.
Yes, they aren't useful. Do they inhibit readability? I don't think
so.
Neither do I. Sergei, your comments are getting very annoying.
It seems you just have some personal bias against me. The comment
was neutral -- I do that every time I notice something of that sort.
Everybody's free to just ignore me.
I don't feel that I should change this line, because it's a move of code
from another function into this function. It's best to leave that code
exactly the same so the reviewer can visual compare the two chunks. If
you care about this coding style issue, go ahead and submit a separate
cleanup patch.
BTW, checkpatch didn't catch this, because my git hooks won't let me
commit without checkpatch passing. Perhaps you'd also like to submit a
patch for that?
checkpatch.pl doesn't catch such things I guess.
No, it's fine as-is. Please continue the great work.
I did not mean to hinder anybody's work. But the patches are posted
here to solicit some comments, not just for silent adoration, aren't
they? At least I thought the purpose was that, otherwise there seems to
be no point in posting to the mail list...
greg k-h
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
