On Sun, May 23, 2010 at 04:42, Sergei Shtylyov wrote: > Mike Frysinger wrote: >> The new MUSB power code needs musb_read_txhubport() to return a value (so >> stub it as 0 like the other Blackfin hub funcs). It also needs new helper >> functions for saving/restoring context, > > No, it doesn't. It was an erratic patch that caused these functions to be > needed outside OMAPs. I've already submitted a patch fixing this, see: > > http://marc.info/?l=linux-usb&m=127427834925805 thanks ... i'll grab whatever gets merged and repost on top of that. >> so change the apparently unused >> musb_platform_{suspend,resume} to musb_platform_{save,restore}_context in >> the Blackfin code. > > I don't see where you're "changing" them -- and no wonder as I have > deleted these two unused functions. the patch was against 2.6.34, but when updating to latest git, the related changes were dropped. but git automerging doesnt fix changelogs for you :p. >> -static inline void musb_read_txhubport(void __iomem *mbase, u8 epnum) >> +static inline u8 musb_read_txhubport(void __iomem *mbase, u8 epnum) >> { >> + return 0; >> } >> #endif /* CONFIG_BLACKFIN */ > > Besides, this actually should have been two patches... it was addressing the same issue: new power code breaks on Blackfin systems -mike -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
