Re: [PATCH 15/15] usb: musb: handle irqs in the order dictated by programming guide

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

Felipe Balbi wrote:

On Thu, Dec 17, 2009 at 03:14:09PM +0100, ext Sergei Shtylyov wrote:
From: Arnaud Mandy <ext-arnaud.2.mandy@xxxxxxxxx>

MUSB's programming guide dictates how we should handle its
irqs and in which order. Follow that.

Signed-off-by: Arnaud Mandy <ext-arnaud.2.mandy@xxxxxxxxx>
Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxx>

 Not sure if it classifies as a fix -- looks quite intrusive...

if you look at it closely, it's actually only moving the code blocks around to match what's dictated on musb's programming guide.

If only it didn't forget to update STAGE0_MASK... or just get rid of it completely as it stopped to make sense. As a result, disconnect and suspend interrupts are ignored now. I wish the patches would get more testing. Fix is coming...

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux