Hi, > Gupta, Ajay Kumar wrote: > > >> AM35x supports only 32bit read operations so we need to have > >> workaround for 8bit and 16bit read operations. > > >> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@xxxxxx> [...] > >> > >> +#if !defined(CONFIG_MACH_OMAP3517EVM) > > > Fixes/workaround based on CONFIG_MACH_OMAP3517EVM will be good only for > > OMAP3517EVM and would not scale well to other boards based on AM35x. > > (As commented earlier by Sergei) > > > I just got to know of another board "LIZARD" based on AM35x so we really > > need to find a solution for this. > > > This problem is due to the fact that AM35x is based on OMAP35x but musb > ip > > Is updated to RTL1.8 using CPPI4.1 DMA engine > > Is that really the only difference? Other difference: USB PHY is built inside the ip itself. Additionally, there is an errata which restricts byte/word (8/16 bit) data read which is due to the bus interface on AM35x. > > > thus we need to have a > > config option to differentiate musb ips between actual OMAP3 and AM35x > > platforms. > > > I am thinking of adding new config option OMAP_MUSB_RTL18 which should > be > > selected by all the boards based on AM35x in arch/arm/mach- > omap2/Kconfig. > > > The same config option can be used for all the workaround/fixes specific > > to AM35x musb platform. > > > ------------------ > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > > index b72ae06..3ab1156 100644 > > --- a/arch/arm/mach-omap2/Kconfig > > +++ b/arch/arm/mach-omap2/Kconfig > > @@ -95,6 +95,7 @@ config MACH_OMAP3517EVM > > bool "OMAP3517/ AM3517 EVM board" > > depends on ARCH_OMAP3 && ARCH_OMAP34XX > > select OMAP_PACKAGE_CBB > > + select OMAP_MUSB_RTL18 > > > > config PMIC_TPS65023 > > bool "TPS65023 Power Module" > > ------------------ > > > > Does anyone has a better option to fix this issue or any comment on this > > approach? > > Why not introduce CONFIG_ARCH_AM35x instead? This is fine with me but don't know if Tony would agree with it. -Ajay > > WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
